[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] net: make network client name unique
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] net: make network client name unique |
Date: |
Thu, 18 Apr 2013 13:25:34 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Apr 15, 2013 at 06:55:19PM +0800, Amos Kong wrote:
> assign_name() creates a name MODEL.NUM, where MODEL is the client's model,
> and NUM is the number of MODELs that already exist.
>
> Markus added NIC naming for non-VLAN clients in commit 53e51d85.
> commit d33d93b2 incorrectly added a judgement of net-hub. It caused
> net clients created with -netdev get same names.
>
> eg:
> # qemu-upstream -device virtio-net-pci,netdev=h1 -netdev tap,id=h1 \
> -device virtio-net-pci,netdev=h2 -netdev tap,id=h2 ..
> (qemu) info network
> virtio-net-pci.0:
> index=0,type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:56
> \ h1:
> index=0,type=tap,ifname=tap0,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
> virtio-net-pci.0:
> index=0,type=nic,model=virtio-net-pci,macaddr=52:54:00:12:34:57
> \ h2:
> index=0,type=tap,ifname=tap1,script=/etc/qemu-ifup,downscript=/etc/qemu-ifdown
>
> This patch removed the check of nic-hub, and created unique names for
> all net clients that have same model.
>
> v2: update commitlog & comments
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> net/net.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[Qemu-devel] 'id' assigned to -device could not be set as net-client name (was Re: Nic devices' name are wrongly repeated), Amos Kong, 2013/04/18