Re: [Qemu-devel] [qom-cpu PATCH 2/7] target-i386/kvm.c: Code formatting changes

[Igor Mammedov]

On Mon, 15 Apr 2013 16:25:35 -0300
Eduardo Habkost <address@hidden> wrote:

> Add appropriate spaces around operators, and break line where it needs
> to be broken to allow feature-words array to be introduced without
> having too-long lines.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
>  target-i386/kvm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 397afeb..375219a 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -610,7 +610,8 @@ int kvm_arch_init_vcpu(CPUState *cs)
>      cpuid_data.cpuid.nent = cpuid_i;
>  
>      if (((env->cpuid_version >> 8)&0xF) >= 6
> -        && (env->cpuid_features&(CPUID_MCE|CPUID_MCA)) ==
> (CPUID_MCE|CPUID_MCA)
> +        && (env->cpuid_features & (CPUID_MCE|CPUID_MCA)) ==
> +            (CPUID_MCE|CPUID_MCA)
small nit,     ^ perhaps better to align it along with statement above
  
>          && kvm_check_extension(cs->kvm_state, KVM_CAP_MCE) > 0) {
>          uint64_t mcg_cap;
>          int banks;

Reviewed-By: Igor Mammedov <address@hidden>