[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/12] target-i386: Consolidate error propagation in
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH 04/12] target-i386: Consolidate error propagation in x86_cpu_realizefn() |
Date: |
Tue, 16 Apr 2013 02:46:41 +0200 |
From: Igor Mammedov <address@hidden>
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
target-i386/cpu.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 0a4e5ae..9d45f09 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2099,9 +2099,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
**errp)
X86CPU *cpu = X86_CPU(dev);
X86CPUClass *xcc = X86_CPU_GET_CLASS(dev);
CPUX86State *env = &cpu->env;
-#ifndef CONFIG_USER_ONLY
Error *local_err = NULL;
-#endif
if (env->cpuid_7_0_ebx_features && env->cpuid_level < 7) {
env->cpuid_level = 7;
@@ -2131,8 +2129,9 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
**errp)
} else {
if (check_cpuid && kvm_check_features_against_host(cpu)
&& enforce_cpuid) {
- error_setg(errp, "Host's CPU doesn't support requested features");
- return;
+ error_setg(&local_err,
+ "Host's CPU doesn't support requested features");
+ goto out;
}
#ifdef CONFIG_KVM
filter_features_for_kvm(cpu);
@@ -2145,8 +2144,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
**errp)
if (cpu->env.cpuid_features & CPUID_APIC || smp_cpus > 1) {
x86_cpu_apic_init(cpu, &local_err);
if (local_err != NULL) {
- error_propagate(errp, local_err);
- return;
+ goto out;
}
}
#endif
@@ -2155,7 +2153,12 @@ static void x86_cpu_realizefn(DeviceState *dev, Error
**errp)
qemu_init_vcpu(&cpu->env);
cpu_reset(CPU(cpu));
- xcc->parent_realize(dev, errp);
+ xcc->parent_realize(dev, &local_err);
+out:
+ if (local_err != NULL) {
+ error_propagate(errp, local_err);
+ return;
+ }
}
/* Enables contiguous-apic-ID mode, for compatibility */
--
1.8.1.4
- [Qemu-devel] [PULL 00/12] QOM CPUState patch queue 2013-04-15, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 02/12] target-i386: Improve -cpu ? features output, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 01/12] target-i386: Fix including "host" in -cpu ? output, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 03/12] qdev: Add qdev property for bool type, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 06/12] kvmvapic: Replace FROM_SYSBUS() with QOM type cast, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 04/12] target-i386: Consolidate error propagation in x86_cpu_realizefn(),
Andreas Färber <=
- [Qemu-devel] [PATCH 07/12] ioapic: Replace FROM_SYSBUS() with QOM type cast, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 05/12] target-i386: Split APIC creation from initialization in x86_cpu_realizefn(), Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 11/12] qdev: Set device's parent before calling realize() down inheritance chain, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 08/12] target-i386/cpu.c: Coding style fixes, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 10/12] cpu: Pass CPUState to *cpu_synchronize_post*(), Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 09/12] target-i386: Split out CPU creation and features parsing, Andreas Färber, 2013/04/15
- [Qemu-devel] [PATCH 12/12] target-cris: Override do_interrupt for pre-v32 CPU cores, Andreas Färber, 2013/04/15