[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/12] tpm: reorganize headers and split hardwar
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH 08/12] tpm: reorganize headers and split hardware part |
Date: |
Mon, 15 Apr 2013 18:19:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
On 04/15/13 15:19, Paolo Bonzini wrote:
> diff --git a/include/backends/tpm.h b/include/backends/tpm.h
> index 9e93cc5..a96b110 100644
> --- a/include/backends/tpm.h
> +++ b/include/backends/tpm.h
> @@ -18,7 +18,7 @@
> #include "qapi/error.h"
> #include "qapi-types.h"
> #include "qemu/option.h"
> -#include "tpm/tpm.h"
> +#include "sysemu/tpm.h"
>
> #define TYPE_TPM_BACKEND "tpm-backend"
> #define TPM_BACKEND(obj) \
> @@ -30,6 +30,7 @@
>
> typedef struct TPMBackendClass TPMBackendClass;
> typedef struct TPMBackend TPMBackend;
> +typedef struct TPMState TPMState;
>
> typedef struct TPMDriverOps TPMDriverOps;
>
This breaks the build for me:
include/sysemu/tpm_backend.h:33: error: redefinition of typedef 'TPMState'
include/sysemu/tpm.h:17: note: previous declaration of 'TPMState' was here
The prev decl. is from 8f0605cc.
"include/sysemu/tpm.h" seems like a "more common" header, so suggesting
to drop the typedef from the backend. Anyway the x86_64 default config
build completes that way.
Thanks,
Laszlo
diff --git a/include/sysemu/tpm_backend.h b/include/sysemu/tpm_backend.h
index a96b110..4667874 100644
--- a/include/sysemu/tpm_backend.h
+++ b/include/sysemu/tpm_backend.h
@@ -30,7 +30,6 @@
typedef struct TPMBackendClass TPMBackendClass;
typedef struct TPMBackend TPMBackend;
-typedef struct TPMState TPMState;
typedef struct TPMDriverOps TPMDriverOps;
[Qemu-devel] [PATCH 01/12] arm: fix location of some include files, Paolo Bonzini, 2013/04/15
[Qemu-devel] [PATCH 05/12] acpi: move declarations from pc.h to acpi.h, Paolo Bonzini, 2013/04/15
[Qemu-devel] [PATCH 09/12] sysemu: avoid proliferation of include/ subdirectories, Paolo Bonzini, 2013/04/15
[Qemu-devel] [PATCH 08/12] tpm: reorganize headers and split hardware part, Paolo Bonzini, 2013/04/15
- Re: [Qemu-devel] [PATCH 08/12] tpm: reorganize headers and split hardware part,
Laszlo Ersek <=
[Qemu-devel] [PATCH 11/12] memory: move core typedefs to qemu/typedefs.h, Paolo Bonzini, 2013/04/15
Re: [Qemu-devel] [PULL 00/12] directory reorganization, fixes and final part, Paolo Bonzini, 2013/04/15
Re: [Qemu-devel] [PULL 00/12] directory reorganization, fixes and final part, Anthony Liguori, 2013/04/15