[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/33] Modernize tcg/ppc64
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/33] Modernize tcg/ppc64 |
Date: |
Sat, 13 Apr 2013 14:24:07 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Apr 04, 2013 at 05:55:53PM -0500, Richard Henderson wrote:
> Changes v3-v4:
>
> There were two problems, both related to the setcond opcode:
>
> * The first was pre-existing: the current code gets 32-bit NE wrong,
> failing to ignore the high 32-bits of the register. This problem
> caused the rest of the patch set to be non-bisectable -- any non-
> trivial change to code generation of the 32-bit opcodes tended to
> expose this.
>
> * The second was in the setcond rewrite, in that my logic was wrong
> for the signed comparisons.
>
> In the process of tracking all of this down, I split up the setcond
> changes into three parts, and dropped the carry-bit optimization part
> entirely. It may still be an improvement for the unsigned comparisons,
> but since I have switched to MFOCRF it'll be harder to show a speedup
> in practice.
>
> Finally, one extra patch to avoid a regression in code generation when
> insertting zero via deposit.
>
> Tested with arm-test, sparc-test, and i386-softmmu nbench.
>
> Tree updated at
>
> git://github.com/rth7680/qemu.git tcg-ppc64
>
Oops it looks like I reviewed the V3, while testing the version in your
git tree, so the V4.
Therefore my comments about the tests I have done apply to this version,
and I'll review the remaining patches of this version over the week-end.
Tested-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v4 28/33] tcg-ppc64: Use ISEL for setcond, (continued)
- [Qemu-devel] [PATCH v4 28/33] tcg-ppc64: Use ISEL for setcond, Richard Henderson, 2013/04/04
- [Qemu-devel] [PATCH v4 30/33] tcg-ppc64: Use getauxval for ISA detection, Richard Henderson, 2013/04/04
- [Qemu-devel] [PATCH v4 31/33] tcg-ppc64: Implement add2/sub2_i64, Richard Henderson, 2013/04/04
- [Qemu-devel] [PATCH v4 29/33] tcg-ppc64: Implement movcond, Richard Henderson, 2013/04/04
- [Qemu-devel] [PATCH v4 32/33] tcg-ppc64: Implement mulu2/muls2_i64, Richard Henderson, 2013/04/04
- [Qemu-devel] [PATCH v4 33/33] tcg-ppc64: Handle deposit of zero, Richard Henderson, 2013/04/04
- Re: [Qemu-devel] [PATCH v4 00/33] Modernize tcg/ppc64,
Aurelien Jarno <=