[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/27] Modernize tcg/ppc64
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/27] Modernize tcg/ppc64 |
Date: |
Sat, 13 Apr 2013 13:38:45 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Apr 01, 2013 at 09:23:03PM -0700, Richard Henderson wrote:
> Changes v2-v3:
> * Incorporated feedback from Aurelien's review.
>
> Tree updated at
>
> git://github.com/rth7680/qemu.git tcg-ppc64
>
> r~
>
>
>
> Richard Henderson (27):
> disas: Disassemble all ppc insns for the host
> tcg-ppc64: Use TCGReg everywhere
> tcg-ppc64: Introduce and use tcg_out_rlw
> tcg-ppc64: Introduce and use tcg_out_ext32u
> tcg-ppc64: Introduce and use tcg_out_shli64
> tcg-ppc64: Introduce and use tcg_out_shri64
> tcg-ppc64: Cleanup tcg_out_movi
> tcg-ppc64: Introduce and use TAI and SAI
> tcg-ppc64: Rearrange integer constant constraints
> tcg-ppc64: Improve constant add and sub ops.
> tcg-ppc64: Tidy or and xor patterns.
> tcg-ppc64: Improve and_i32 with constant
> tcg-ppc64: Improve and_i64 with constant
> tcg-ppc64: Streamline qemu_ld/st insn selection
> tcg-ppc64: Implement rotates
> tcg-ppc64: Implement bswap16 and bswap32
> tcg-ppc64: Implement bswap64
> tcg-ppc64: Implement compound logicals
> tcg-ppc64: Handle constant inputs for some compound logicals
> tcg-ppc64: Implement deposit
> tcg-ppc64: Use I constraint for mul
> tcg-ppc64: Use TCGType throughout compares
> tcg-ppc64: Rewrite setcond
> tcg-ppc64: Implement movcond
> tcg-ppc64: Use getauxval for ISA detection
> tcg-ppc64: Implement add2/sub2_i64
> tcg-ppc64: Implement mulu2/muls2_i64
>
> configure | 18 +
> disas.c | 1 +
> tcg/ppc64/tcg-target.c | 1395
> +++++++++++++++++++++++++++++++++---------------
> tcg/ppc64/tcg-target.h | 60 ++-
> 4 files changed, 1000 insertions(+), 474 deletions(-)
>
Please find the review in the individual patches. Except minor nitpicks
in patch 16, the series looks fine for me.
I have tested it with arm, i386, mips(64), mips(64)el, powerpc, sh4 and sparc
guests without problem. OTOH it didn't work for me for x86_64 guests,
which hangs in the boot process (both Linux and FreeBSD). i386 guests
using qemu-system-x86_64 works fine though.
So it's a huge improvement considering it was not working for half of
these guests before. Thanks.
Tested-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v3 22/27] tcg-ppc64: Use TCGType throughout compares, (continued)
- [Qemu-devel] [PATCH v3 22/27] tcg-ppc64: Use TCGType throughout compares, Richard Henderson, 2013/04/02
- [Qemu-devel] [PATCH v3 23/27] tcg-ppc64: Rewrite setcond, Richard Henderson, 2013/04/02
- [Qemu-devel] [PATCH v3 24/27] tcg-ppc64: Implement movcond, Richard Henderson, 2013/04/02
- [Qemu-devel] [PATCH v3 25/27] tcg-ppc64: Use getauxval for ISA detection, Richard Henderson, 2013/04/02
- [Qemu-devel] [PATCH v3 26/27] tcg-ppc64: Implement add2/sub2_i64, Richard Henderson, 2013/04/02
- [Qemu-devel] [PATCH v3 27/27] tcg-ppc64: Implement mulu2/muls2_i64, Richard Henderson, 2013/04/02
- Re: [Qemu-devel] [PATCH v3 00/27] Modernize tcg/ppc64, Alexander Graf, 2013/04/02
- Re: [Qemu-devel] [PATCH v3 00/27] Modernize tcg/ppc64,
Aurelien Jarno <=