[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots |
Date: |
Thu, 11 Apr 2013 14:03:10 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 |
>> # Statistics of a virtual block device or a block backing device.
>> diff --git a/qmp-commands.hx b/qmp-commands.hx
>> index 1e0e11e..6b20684 100644
>> --- a/qmp-commands.hx
>> +++ b/qmp-commands.hx
>> @@ -1765,6 +1765,61 @@ EQMP
>> },
>>
>> SQMP
>> +query-snapshots
>> +---------------
>> +
>> +Show the internal consistent snapshot information
>> +
>> +Each snapshot is represented by a json-object. The returned value
>> +is a json-array of all snapshots
>> +
>> +Each json-object contain the following:
>> +
>> +- "id": unique snapshot id (json-string)
>> +- "name": internal snapshot name (json-string)
>> +- "vm-state-size": size of the VM state in bytes (json-int)
>> +- "date-sec": UTC date of the snapshot in seconds (json-int)
>> +- "date-nsec": fractional part in nanoseconds to be used with
>> + date-sec(json-int)
>> +- "vm-clock-sec": VM clock relative to boot in seconds (json-int)
>> +- "vm-clock-nsec": fractional part in nanoseconds to be used with
>> + vm-clock-sec (json-int)
>> +
>> +Example:
>> +
>> +-> { "execute": "query-snapshots" }
>> +<- {
>> + "return":[
>> + {
>> + "id": "1",
>> + "name": "snapshot1",
>> + "vm-state-size": 0,
>> + "date-sec": 10000200,
>> + "date-nsec": 12,
>> + "vm-clock-sec": 206,
>> + "vm-clock-nsec": 30
>
> Not your patch's fault, but here goes anyway: I dislike this
> representation of time.
>
> QMP has time in seconds, milliseconds, nanoseconds, (seconds,
> milliseconds) and (seconds, nanoseconds). There has been no adult
> supervision, obviously (I may say that, because it's as much my fault as
> it's anybody else's).
>
> The sanest one by far is nanoseconds. Good for 2^63 of them. Since pi
> seconds is a nanocentury, good for 2^63 / (pi * 1e9) centuries, which
> should be safely beyond your retirement age.
>
OK, will insert a patch before removing "vm-clock-sec". Have one
question: how to declare uint64_t in qmp-schema.json?
>> + },
>> + {
>> + "id": "2",
>> + "name": "snapshot2",
>> + "vm-state-size": 34000000,
>> + "date-sec": 13000200,
>> + "date-nsec": 32,
>> + "vm-clock-sec": 406,
>> + "vm-clock-nsec": 31
>> + }
>> + ]
>> + }
>> +
>> +EQMP
>> +
>> + {
>> + .name = "query-snapshots",
>> + .args_type = "",
>> + .mhandler.cmd_new = qmp_marshal_input_query_snapshots,
>> + },
>> +
>> +SQMP
>> query-blockstats
>> ----------------
>
--
Best Regards
Wenchao Xia
- Re: [Qemu-devel] [PATCH V11 05/17] block: add snapshot info query function bdrv_query_snapshot_info_list(), (continued)
[Qemu-devel] [PATCH V11 06/17] block: add check for VM snapshot in bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/04/02
[Qemu-devel] [PATCH V11 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c, Wenchao Xia, 2013/04/02
[Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/02
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Stefan Hajnoczi, 2013/04/08
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Markus Armbruster, 2013/04/10
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots,
Wenchao Xia <=
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Markus Armbruster, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Luiz Capitulino, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Eric Blake, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Luiz Capitulino, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Eric Blake, 2013/04/11
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Wenchao Xia, 2013/04/12
- Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots, Markus Armbruster, 2013/04/12
[Qemu-devel] [PATCH V11 10/17] qmp: add recursive member in ImageInfo, Wenchao Xia, 2013/04/02