[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS(
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast |
Date: |
Wed, 10 Apr 2013 18:12:15 +0200 |
On Wed, 10 Apr 2013 08:21:17 +0800
li guang <address@hidden> wrote:
> 在 2013-04-09二的 13:36 +0200,Paolo Bonzini写道:
> > Il 08/04/2013 13:32, Igor Mammedov ha scritto:
> > >
> > >> > This patch should be combined with [PATCH 07/22]
> > >> >
> > >> > 在 2013-04-05五的 16:37 +0200,Igor Mammedov写道:
> > >>> > > Signed-off-by: Igor Mammedov <address@hidden>
> > >>> > > ---
> > >>> > > hw/ioapic_common.c | 2 +-
> > >>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>> > >
> > >>> > > diff --git a/hw/ioapic_common.c b/hw/ioapic_common.c
> > >>> > > index d4aff29..561b987 100644
> > >>> > > --- a/hw/ioapic_common.c
> > >>> > > +++ b/hw/ioapic_common.c
> > >>> > > @@ -59,7 +59,7 @@ static int ioapic_dispatch_post_load(void
> > >>> > > *opaque, int version_id)
> > >>> > > static int ioapic_init_common(SysBusDevice *dev)
> > >>> > > {
> > >>> > > - IOAPICCommonState *s = FROM_SYSBUS(IOAPICCommonState, dev);
> > >>> > > + IOAPICCommonState *s = IOAPIC_COMMON(dev);
> > >>> > > IOAPICCommonClass *info;
> > >>> > > static int ioapic_no;
> > >>> > >
> > >> >
> > >> >
> > >> >
> > > sure, will do this on the next respin.
> >
> > Actually no, why? It's two different files.
>
> because they do the same trivial thing,
> do you want some mechanic changes separated?
There is no point arguing,
Andreas applied the first patch to qom-cpu tree already,
and seems he is fine taking them as separate patches.
- Re: [Qemu-devel] [PATCH 03/22] target-i386: split out CPU creation and features parsing into cpu_x86_create(), (continued)
[Qemu-devel] [PATCH 07/22] target-i386: kvmvapic: replace FROM_SYSBUS() with QOM type cast, Igor Mammedov, 2013/04/05
[Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast, Igor Mammedov, 2013/04/05
- Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast, li guang, 2013/04/07
- Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast, Igor Mammedov, 2013/04/08
- Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast, Paolo Bonzini, 2013/04/09
- Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast, li guang, 2013/04/09
- Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast, Paolo Bonzini, 2013/04/10
- Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast,
Igor Mammedov <=
- Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast, Andreas Färber, 2013/04/10
Re: [Qemu-devel] [PATCH 08/22] target-i386: ioapic: replace FROM_SYSBUS() with QOM type cast, Andreas Färber, 2013/04/10
[Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method, Igor Mammedov, 2013/04/05
[Qemu-devel] [PATCH 13/22] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest, Igor Mammedov, 2013/04/05