Re: [Qemu-devel] [PATCH] sh7750: Fix crash when accessing PVR/PRR/CVR

[Andreas Färber]

Am 08.04.2013 14:52, schrieb Peter Maydell:
> On 26 March 2013 14:35, Andreas Färber <address@hidden> wrote:
>> Am 26.03.2013 13:20, schrieb Peter Maydell:
>>> Commit b350ab75 causes segfaults on accesses to PVR/PRR/CVR because
>>> it tries to call SUPERH_CPU_GET_CLASS() on a pointer that isn't a
>>> QOM object. Fix this by getting the actual QOM CPU object first.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>> ---
>>> Tested with the r2d image/instructions from
>>> https://oss.renesas.com/modules/document/?Getting%20Started%20with%20SH4%20and%20QEMU
>>
>> Oops, reproduces with the test image from the QEMU Wiki as well. Seems
>> to be a result of cherry-picking this commit before the full SH7750
>> QOM'ification.
>>
>> Is this blocking any work of yours? Otherwise I would try rebasing my
>> SH7750 patches so that s->cpu becomes a SuperHCPU as expected here.
>> (Not sure if simply reverting my offending patch still works?)
> 
> Ping -- were you planning to submit these patches soon or should
> we just commit this patch to fix the breakage for now?

Submitted now, sorry for the delay.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg