[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/3] aio-context: if io_flush isn't provided
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/3] aio-context: if io_flush isn't provided, assume "always busy" |
|
Date: |
Mon, 8 Apr 2013 17:28:41 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 29, 2013 at 12:37:18AM +0100, Paolo Bonzini wrote:
> Il 28/03/2013 22:52, Anthony Liguori ha scritto:
> > Today, all callers of qemu_aio_set_fd_handler() pass a valid io_flush
> > function.
>
> Except one:
>
> aio_set_event_notifier(ctx, &ctx->notifier,
> (EventNotifierHandler *)
> event_notifier_test_and_clear, NULL);
>
> This is the EventNotifier that is used by qemu_notify_event.
>
> It's quite surprising that this patch works and passes the tests. /me
> reads cover letter... ah, it is untested. :)
This one instance is easy enough to fix by a return 0 io_flush handler.
Stefan