[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/24] xen: re-enable refresh interval reporting
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 20/24] xen: re-enable refresh interval reporting for xenfb |
Date: |
Fri, 05 Apr 2013 09:28:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 |
>> -#else
>> ; /* nothing */
>> -#endif
>> } else {
>> /* we don't get update notifications, thus use the
>> * sledge hammer approach ... */
>
> You might as well remove the if () nothing; case.
Yep, will do.
>> @@ -785,6 +755,20 @@ static void xenfb_update(void *opaque)
>> xenfb->up_fullscreen = 0;
>> }
>>
>> +static void xenfb_update_interval(void *opaque, uint64_t interval)
>> +{
>> + struct XenFB *xenfb = opaque;
>> +
>> + if (xenfb->feature_update) {
>> +#ifdef XENFB_TYPE_REFRESH_PERIOD
>> + if (xenfb_queue_full(xenfb)) {
>> + return;
>> + }
>> + xenfb_send_refresh_period(xenfb, interval);
>
> Shouldn't we be updating xenfb->refresh_period here? And shouldn't we
> call xenfb_send_refresh_period only if interval !=
> xenfb->refresh_period?
> On the other hand if refresh_period is not useful anymore, shouldn't
> we remove it from struct XenFB?
xenfb_update_interval is only called when interval changes, which I
think means we don't need refresh_period any more, correct?
cheers,
Gerd
- [Qemu-devel] [PATCH 05/24] pixman: add qemu_pixman_color(), (continued)
- [Qemu-devel] [PATCH 05/24] pixman: add qemu_pixman_color(), Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 17/24] console: make DisplayState private to console.c, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 19/24] console: gui timer fixes, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 01/24] exynos4210_fimd.c: fix display resize bug introduced after console revamp, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 21/24] console: add qemu_console_is_*, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 12/24] console: rename vga_hw_*, add QemuConsole param, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 24/24] qxl: register QemuConsole for secondary cards, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 23/24] gtk: custom cursor support, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 20/24] xen: re-enable refresh interval reporting for xenfb, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 16/24] console: move gui_update+gui_setup_refresh from vl.c into console.c, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 22/24] console: allow pinning displaychangelisteners to consoles, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 14/24] console: simplify screendump, Gerd Hoffmann, 2013/04/04
- [Qemu-devel] [PATCH 18/24] console: add GraphicHwOps, Gerd Hoffmann, 2013/04/04