Re: [Qemu-devel] [PATCH 0/2] Drop support for qdev taddr properties

[Peter Maydell]

On 2 April 2013 21:39, Paolo Bonzini <address@hidden> wrote:
> "Peter Maydell" <address@hidden> wrote:
>> I'm confused. Do you mean that it's changed so that spapr passes
>> a MemoryRegion* rather than a DMAContext*, or so that everything
>> uses a DMAContext* ? (The comments in pci.c suggest that the former
>> is the intended approach.)
>
> Yes, the former.  More precisely, everything uses an AddressSpace*,
> in fact (that was the part that Avi didn't write) dma-helpers.c can
> use AddressSpace* instead of DMAContext*.
>
> spapr right now needs a special translate pointer embedded in the
> DMAContext.  With the iommu MemoryRegion patches, it can put the
> translate function pointer into a translation MemoryRegion.  Then
> the AddressSpace points to that MemoryRegion.

Ah, right, good. It would certainly be good to see those patches;
there's a potential followup to the versatile_pci patches that
implements the device-to-system access windows properly which
should probably be based on top of them.

-- PMM