Re: [Qemu-devel] [PATCH 1/5] configure: move TARGET_*_ALIGNMENT to target-*/cpu.h

[Peter Maydell]

On 2 April 2013 15:44, Paolo Bonzini <address@hidden> wrote:
> This is no different from, for example, TARGET_LONG_BITS.  It does
> not belong in configure.

> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 42c36e2..19d4e4c 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -27,6 +27,7 @@
>  #if defined (TARGET_PPC64)
>  /* PowerPC 64 definitions */
>  #define TARGET_LONG_BITS 64
> +#define TARGET_LONG_ALIGNMENT 8
>  #define TARGET_PAGE_BITS 12

Doesn't this incorrectly set the long alignment to 8
for ppc64abi32? (Probably similar problem for
sparc32plus and mipsn32. The underlying point here is that
alignment is an ABI decision and you can have more than one
ABI for a particular TARGET_FOO.)

-- PMM