[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V10 08/17] block: move qmp_query_block() and bdr
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V10 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c |
Date: |
Fri, 29 Mar 2013 14:10:07 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/22/2013 08:19 AM, Wenchao Xia wrote:
> This is a code move patch, except in qmp_query_block bdrv_next(bs)
> is used instead of direct traverse of global array 'bdrv_states'.
Mixing code motion and a code change isn't always the best, but at least
you were honest about it. I don't know how easy it would be to split
this into two patches for straight code motion.
> This patch also fix code style error reported by check script.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block.c | 76 ------------------------------------------------
> block/qapi.c | 77
> +++++++++++++++++++++++++++++++++++++++++++++++++
> include/block/block.h | 1 -
> include/block/qapi.h | 1 +
> 4 files changed, 78 insertions(+), 77 deletions(-)
At any rate,
Reviewed-by: Eric Blake <address@hidden>
> -BlockInfoList *qmp_query_block(Error **errp)
> -{
> - BlockInfoList *head = NULL, **p_next = &head;
> - BlockDriverState *bs;
> -
> - QTAILQ_FOREACH(bs, &bdrv_states, list) {
> +BlockInfoList *qmp_query_block(Error **errp)
> +{
> + BlockInfoList *head = NULL, **p_next = &head;
> + BlockDriverState *bs = NULL;
> +
> + while ((bs = bdrv_next(bs))) {
This is the tweak you made.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V10 00/17] qmp/hmp interfaces for internal snapshot info, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 01/17] block: move bdrv_snapshot_find() to block/snapshot.c, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 02/17] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 03/17] qemu-img: remove unused parameter in collect_image_info(), Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 04/17] block: move collect_snapshots() and collect_image_info() to block/qapi.c, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 06/17] block: add check for VM snapshot in bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 05/17] block: add snapshot info query function bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c, Wenchao Xia, 2013/03/22
- Re: [Qemu-devel] [PATCH V10 08/17] block: move qmp_query_block() and bdrv_query_info() to block/qapi.c,
Eric Blake <=
- [Qemu-devel] [PATCH V10 09/17] qmp: add interface query-snapshots, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 07/17] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 10/17] qmp: add recursive member in ImageInfo, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 12/17] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/03/22