[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/20] tcg-arm: Allow constant first argument
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/20] tcg-arm: Allow constant first argument to sub |
Date: |
Fri, 29 Mar 2013 17:58:03 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Mar 28, 2013 at 08:32:44AM -0700, Richard Henderson wrote:
> This allows the generation of RSB instructions.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/arm/tcg-target.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index f470caa..7475142 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -1665,8 +1665,17 @@ static inline void tcg_out_op(TCGContext *s, TCGOpcode
> opc,
> args[0], args[1], args[2], const_args[2]);
> break;
> case INDEX_op_sub_i32:
> - tcg_out_dat_rIN(s, COND_AL, ARITH_SUB, ARITH_ADD,
> - args[0], args[1], args[2], const_args[2]);
> + if (const_args[1]) {
> + if (const_args[2]) {
> + tcg_out_movi32(s, COND_AL, args[0], args[1] - args[2]);
> + } else {
> + tcg_out_dat_rI(s, COND_AL, ARITH_RSB,
> + args[0], args[2], args[1], 1);
> + }
> + } else {
> + tcg_out_dat_rIN(s, COND_AL, ARITH_SUB, ARITH_ADD,
> + args[0], args[1], args[2], const_args[2]);
> + }
> break;
> case INDEX_op_and_i32:
> tcg_out_dat_rIK(s, COND_AL, ARITH_AND, ARITH_BIC,
> @@ -1859,7 +1868,7 @@ static const TCGTargetOpDef arm_op_defs[] = {
>
> /* TODO: "r", "r", "ri" */
> { INDEX_op_add_i32, { "r", "r", "rIN" } },
> - { INDEX_op_sub_i32, { "r", "r", "rIN" } },
> + { INDEX_op_sub_i32, { "r", "rI", "rIN" } },
> { INDEX_op_mul_i32, { "r", "r", "r" } },
> { INDEX_op_mulu2_i32, { "r", "r", "r", "r" } },
> { INDEX_op_muls2_i32, { "r", "r", "r", "r" } },
Reviewed-by: Aurelien Jarno <address@hidden>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v3 04/20] tcg-arm: Use tcg_out_dat_rIN for compares, (continued)
[Qemu-devel] [PATCH v3 03/20] tcg-arm: Allow constant first argument to sub, Richard Henderson, 2013/03/28
- Re: [Qemu-devel] [PATCH v3 03/20] tcg-arm: Allow constant first argument to sub,
Aurelien Jarno <=
[Qemu-devel] [PATCH v3 06/20] tcg-arm: Improve constant generation, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 07/20] tcg-arm: Fold epilogue into INDEX_op_exit_tb, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 08/20] tcg-arm: Implement deposit for armv7, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 09/20] tcg-arm: Implement division instructions, Richard Henderson, 2013/03/28
[Qemu-devel] [PATCH v3 10/20] tcg-arm: Use TCG_REG_TMP name for the tcg temporary, Richard Henderson, 2013/03/28