[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 5/6] pc_piix, pc_q35: export fw_cfg
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v16 5/6] pc_piix, pc_q35: export fw_cfg |
Date: |
Fri, 29 Mar 2013 10:28:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 29/03/2013 09:16, Hu Tao ha scritto:
> diff --git a/hw/pc.h b/hw/pc.h
> index 8e1dd4c..d42b76b 100644
> --- a/hw/pc.h
> +++ b/hw/pc.h
> @@ -145,6 +145,12 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state, int
> *piix_devfn,
> extern PCIDevice *piix4_dev;
> int piix4_init(PCIBus *bus, ISABus **isa_bus, int devfn);
>
> +/* pc_piix.c */
> +extern void *fw_cfg_piix;
> +
> +/* pc_q35.c */
> +extern void *fw_cfg_q35;
> +
> /* vga.c */
> enum vga_retrace_method {
> VGA_RETRACE_DUMB,
>
Hu, this is not what I suggested in the review...
Please do not ignore comments without answer, otherwise we'll just run
in circles.
Paolo
- [Qemu-devel] [PATCH v16 0/6] Add pvpanic device to deal with guest panic event, Hu Tao, 2013/03/29
- [Qemu-devel] [PATCH v16 2/6] add a new qevent: QEVENT_GUEST_PANICKED, Hu Tao, 2013/03/29
- [Qemu-devel] [PATCH v16 3/6] introduce a new qom device to deal with panicked event, Hu Tao, 2013/03/29
- [Qemu-devel] [PATCH v16 5/6] pc_piix, pc_q35: export fw_cfg, Hu Tao, 2013/03/29
- Re: [Qemu-devel] [PATCH v16 5/6] pc_piix, pc_q35: export fw_cfg,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v16 6/6] pvpanic: pass configurable ioport to seabios, Hu Tao, 2013/03/29
- [Qemu-devel] [PATCH v16 4/6] pvpanic: add document of pvpanic, Hu Tao, 2013/03/29
- [Qemu-devel] [PATCH v16 1/6] add a new runstate: RUN_STATE_GUEST_PANICKED, Hu Tao, 2013/03/29
- [Qemu-devel] [PATCH v16] Add pvpanic device driver, Hu Tao, 2013/03/29