[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [patch]Make GTK build on OS X
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [patch]Make GTK build on OS X |
|
Date: |
Thu, 28 Mar 2013 02:21:00 -0400 (EDT) |
> > Yes, I know. The point is that there's already an idiom to choose
> > between pty.h/util.h/libutil.h, and we should not introduce
> > another.
>
> Note that mingw has none of those headers, so double-check the _WIN32
> conditionals.
Good catch. C.W., the right include file is include/sysemu/os-posix.h.
My mistake, sorry.
Paolo
> >
> > Paolo
> >
> >>>
> >>> #if defined(__GLIBC__)
> >>> #include <pty.h>
> >>> #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||
> >>> defined(__DragonFly__)
> >>> #include <libutil.h>
> >>> #else
> >>> #include <util.h>
> >>> #endif
> >>>
> >>> Please move it to include/qemu-common.h instead so that there is
> >>> no
> >>> duplication.
> >> The next patch will do this. Thank you for the feedback.
> >>>
> >>> Paolo
> >>>
> >>
> >>
> >
> >
> >
> >
>
>