Re: [Qemu-devel] [PATCH 0/4] monitor: do not rely on O_NONBLOCK for passed file descriptors

[Juan Quintela]

Stefan Hajnoczi <address@hidden> wrote:
> On Wed, Mar 27, 2013 at 04:37:52PM +0800, liu ping fan wrote:
>> On Wed, Mar 27, 2013 at 12:07 AM, Stefan Hajnoczi <address@hidden> wrote:
>> > There are several places where QEMU accidentally relies on the
>> > O_NONBLOCK state
>> > of passed file descriptors.  Exposing O_NONBLOCK state makes it
>> > part of the QMP
>> 
>> If in future, we push more backend on their dedicated thread, will the
>> related fd be block?
>
> This series is not related to threading in QEMU.  The convention it
> establishes is that passed fds are blocking.  If QEMU wants to use
                                     ^^^^^^^^
You mean here non-blocking

> nonblocking it must call qemu_set_block(fd).  This works whether it is
                           ^^^^^^^^^^^^^^^^^^
or here qemu_set_nonblock(fd)

no?

I guess the second one O:-)

Later, Juan.

> done from a traditional QEMU thread or a data plane thread.
>
> Stefan