[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/12] savevm: add error parameter to qemu_sa
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/12] savevm: add error parameter to qemu_savevm_state_complete() |
Date: |
Tue, 26 Mar 2013 13:41:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/22/2013 07:16 AM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <address@hidden>
> ---
> include/sysemu/sysemu.h | 2 +-
> migration.c | 2 +-
> savevm.c | 5 +++--
> 3 files changed, 5 insertions(+), 4 deletions(-)
>
> @@ -1734,6 +1734,7 @@ void qemu_savevm_state_complete(QEMUFile *f)
> trace_savevm_section_end(se->section_id);
> if (ret < 0) {
> qemu_file_set_error(f, ret);
> + error_setg(errp, "Failed to complete vmstate save.");
I know I said I wouldn't keep mentioning error message conventions...
therefore, I'm okay if you fix things, and add:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/12] convert savevm to use qapi and introduce qmp command, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 01/12] block: add error parameter to bdrv_snapshot_create() and related functions, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 02/12] block: add error parameter to del_existing_snapshots(), Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 03/12] savevm: add error parameter to qemu_savevm_state_begin(), Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 05/12] savevm: add error parameter to qemu_savevm_state_complete(), Pavel Hrdina, 2013/03/22
- Re: [Qemu-devel] [PATCH v2 05/12] savevm: add error parameter to qemu_savevm_state_complete(),
Eric Blake <=
- [Qemu-devel] [PATCH v2 04/12] savevm: add error parameter to qemu_savevm_state_iterate(), Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 07/12] qapi: Convert savevm, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 06/12] savevm: add error parameter to qemu_savevm_state(), Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 08/12] qemu-img: introduce qemu_img_handle_error, Pavel Hrdina, 2013/03/22
- [Qemu-devel] [PATCH v2 10/12] savevm: update return value from qemu_savevm_state, Pavel Hrdina, 2013/03/22