[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] qemu-socket: set passed fd non-blocking in
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] qemu-socket: set passed fd non-blocking in socket_connect() |
Date: |
Tue, 26 Mar 2013 17:33:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Stefan Hajnoczi <address@hidden> wrote:
> socket_connect() sets non-blocking on TCP or UNIX domain sockets if a
> callback function is passed. Do the same for file descriptor passing,
> otherwise we could unexpectedly be using a blocking file descriptor.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> util/qemu-sockets.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index b6b78f5..298f6f2 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -910,6 +910,7 @@ int socket_connect(SocketAddress *addr, Error **errp,
> case SOCKET_ADDRESS_KIND_FD:
> fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
> if (callback) {
> + socket_set_nonblock(fd);
> callback(fd, opaque);
> }
> break;
Reviewed-by: Juan Quintela <address@hidden>