[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx h
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation |
Date: |
Tue, 26 Mar 2013 09:26:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-03-25 21:30, Gerd Hoffmann wrote:
> On 03/25/13 14:56, Igor Mitsyanko wrote:
>> On 03/25/2013 02:37 PM, Gerd Hoffmann wrote:
>>>
>>>> Hi,
>>>>
>>>> [5425.580115] displaysurface_create_from surface=0x7ff315d3df40,
>>>>> 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free
>>>>> surface=0x7ff3158c33b0
>>>>>
>>>>
>>>> This is vga=0x314
>>>>
>>>> Looks like we have some funky interaction between vga and vmware.
>>>>
>>>> I'll go dig. Meanwhile you can try vga=0x315 (800x600x24) or
>>>> vga=normal (textmode), that has a high chance to workaround this.
>>>>
>>>> cheers,
>>>> Gerd
>>>>
>>>
>>>
>>
>> Couldn't it be because wred, wgreen and wblue were removed? It seems like
>> it was a workaround for some pre-existing problem, is it ok that you
>> removed them but left depth and bypp intact?
>
> No, it is not, and yes, this is where the inconsistency comes from. We
> read wred+wgreen+wblue directly from the surface whereas depth is cached
> in the vmware vga state struct. Patch attached. Not fully tested yet.
Unfortunately, this doesn't change the picture (except for the expected
"vmsvga_value_read: Bad register 1c"). The 0x315 workaround does indeed
work.
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, (continued)
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Jan Kiszka, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Gerd Hoffmann, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Jan Kiszka, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Gerd Hoffmann, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Jan Kiszka, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Jan Kiszka, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Gerd Hoffmann, 2013/03/25
- Message not available
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Igor Mitsyanko, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, Gerd Hoffmann, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation, BALATON Zoltan, 2013/03/25
- Re: [Qemu-devel] [PATCH 16/18] console: stop using DisplayState in gfx hardware emulation,
Jan Kiszka <=
[Qemu-devel] [PATCH 18/18] console: remove ds_get_* helper functions, Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 17/18] console: zap color_table, Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 07/18] console: rework DisplaySurface handling [vga emu side], Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 15/18] console: zap displaystate from dcl callbacks, Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 12/18] sdl: stop using DisplayState, Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 11/18] vnc: stop using DisplayState, Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 08/18] console: rework DisplaySurface handling [dcl/ui side], Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 09/18] console: add surface_*() getters, Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 13/18] spice: stop using DisplayState, Gerd Hoffmann, 2013/03/12
[Qemu-devel] [PATCH 14/18] cocoa: stop using DisplayState, Gerd Hoffmann, 2013/03/12