[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/10] versatile_pci: Implement the correct PCI
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 07/10] versatile_pci: Implement the correct PCI IRQ mapping |
|
Date: |
Mon, 25 Mar 2013 12:17:39 +0000 |
On 25 March 2013 12:12, Michael S. Tsirkin <address@hidden> wrote:
> On Sun, Mar 24, 2013 at 11:32:37AM +0000, Peter Maydell wrote:
>> + return (PCI_SLOT(d->devfn) + irq_num - 2) % PCI_NUM_PINS;
>
> It seems this can be a bit shorter:
> pci_swizzle_map_irq_fn(d, irq_num - 2)
> and below irq_num - 1 ?
Yes (though does pci_swizzle_map_irq_fn() accept negative
pin values deliberately or by fluke? it might be better to
use irq_num + 2 / + 3 , maybe.)
-- PMM
- Re: [Qemu-devel] [PATCH 02/10] versatile_pci: Expose PCI I/O region on Versatile PB, (continued)
[Qemu-devel] [PATCH 01/10] versatile_pci: Fix hardcoded tabs, Peter Maydell, 2013/03/24
[Qemu-devel] [PATCH 10/10] versatile_pci: Expose PCI memory space to system, Peter Maydell, 2013/03/24
[Qemu-devel] [PATCH 09/10] arm/realview: Fix mapping of PCI regions, Peter Maydell, 2013/03/24
[Qemu-devel] [PATCH 08/10] versatile_pci: Implement the PCI controller's control registers, Peter Maydell, 2013/03/24
[Qemu-devel] [PATCH 06/10] versatile_pci: Put the host bridge PCI device at slot 29, Peter Maydell, 2013/03/24
[Qemu-devel] [PATCH 03/10] versatile_pci: Update to realize and instance init functions, Peter Maydell, 2013/03/24
[Qemu-devel] [PATCH 07/10] versatile_pci: Implement the correct PCI IRQ mapping, Peter Maydell, 2013/03/24
[Qemu-devel] [PATCH 05/10] versatile_pci: Use separate PCI I/O space rather than system I/O space, Peter Maydell, 2013/03/24
[Qemu-devel] [PATCH 04/10] versatile_pci: Change to subclassing TYPE_PCI_HOST_BRIDGE, Peter Maydell, 2013/03/24
Re: [Qemu-devel] [PATCH 00/10] Fix versatile_pci (and break versatilepb linux guests!), Aurelien Jarno, 2013/03/24