[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/9] Add socket_writev_buffer function
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/9] Add socket_writev_buffer function |
Date: |
Thu, 21 Mar 2013 17:55:29 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Orit Wasserman <address@hidden> wrote:
D> Signed-off-by: Orit Wasserman <address@hidden>
> ---
> savevm.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/savevm.c b/savevm.c
> index 35c8d1e..baa45ae 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -39,6 +39,7 @@
> #include "qmp-commands.h"
> #include "trace.h"
> #include "qemu/bitops.h"
> +#include "qemu/iov.h"
>
> #define SELF_ANNOUNCE_ROUNDS 5
>
> @@ -171,6 +172,18 @@ static void coroutine_fn yield_until_fd_readable(int fd)
> qemu_coroutine_yield();
> }
>
> +static int socket_writev_buffer(void *opaque, struct iovec *iov, int iovcnt)
> +{
> + QEMUFileSocket *s = opaque;
> + ssize_t len;
> +
> + len = iov_send(s->fd, iov, iovcnt, 0, iov_size(iov, iovcnt));
> + if (len < iov_size(iov, iovcnt)) {
Not the more expensive operation ever, but we can factor
iov_size(iov, iovcnt)
value into one variable.
> + len = -socket_error();
> + }
> + return len;
> +}
> +
> static int socket_get_fd(void *opaque)
> {
> QEMUFileSocket *s = opaque;
> @@ -387,6 +400,7 @@ static const QEMUFileOps socket_read_ops = {
> static const QEMUFileOps socket_write_ops = {
> .get_fd = socket_get_fd,
> .put_buffer = socket_put_buffer,
> + .writev_buffer = socket_writev_buffer,
> .close = socket_close
> };
- [Qemu-devel] [PATCH v3 0/9] Migration: Remove copying of guest ram pages, Orit Wasserman, 2013/03/21
- [Qemu-devel] [PATCH v3 2/9] Add socket_writev_buffer function, Orit Wasserman, 2013/03/21
- Re: [Qemu-devel] [PATCH v3 2/9] Add socket_writev_buffer function,
Juan Quintela <=
- [Qemu-devel] [PATCH v3 1/9] Add QemuFileWritevBuffer QemuFileOps, Orit Wasserman, 2013/03/21
- [Qemu-devel] [PATCH v3 3/9] Update bytes_xfer in qemu_put_byte, Orit Wasserman, 2013/03/21
- [Qemu-devel] [PATCH v3 4/9] Store the data to send also in iovec, Orit Wasserman, 2013/03/21
- [Qemu-devel] [PATCH v3 5/9] Use writev ops if available, Orit Wasserman, 2013/03/21