[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing |
|
Date: |
Tue, 19 Mar 2013 20:07:14 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/18/2013 11:23 AM, Kevin Wolf wrote:
> bdrv_open() uses two different variables called options. Rename one of
> them to avoid confusion and to allow the outer one to be accessed
> everywhere.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
Should configure be setting up -Wshadow to help prevent instances like this?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 01/11] block: Add options QDict to bdrv_file_open() prototypes, (continued)
- [Qemu-devel] [PATCH 01/11] block: Add options QDict to bdrv_file_open() prototypes, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 07/11] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 06/11] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/18
- Re: [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing,
Eric Blake <=
- [Qemu-devel] [PATCH 10/11] block: Allow omitting the file name when using driver-specific options, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is specified, Kevin Wolf, 2013/03/18