[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][RFC 02/14] qdev: add power management method
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH][RFC 02/14] qdev: add power management method |
Date: |
Mon, 18 Mar 2013 09:25:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 |
Am 13.03.2013 09:01, schrieb liguang:
> In fact, every devices have to be aware of
> it's power management, so it can decide what
> to do when platform board switch it's power
> state between on/off/suspend/wakeup.
>
> Signed-off-by: liguang <address@hidden>
> ---
> hw/qdev-core.h | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/hw/qdev-core.h b/hw/qdev-core.h
> index 2486f36..e69c50b 100644
> --- a/hw/qdev-core.h
> +++ b/hw/qdev-core.h
> @@ -85,6 +85,12 @@ typedef struct DeviceClass {
> Property *props;
> int no_user;
>
> + /* power management */
> + void (*on)(DeviceState *dev);
> + void (*off)(DeviceState *dev);
> + void (*suspend)(DeviceState *dev);
> + void (*wakeup)(DeviceState *dev);
> +
> /* callbacks */
> void (*reset)(DeviceState *dev);
> DeviceRealize realize;
Whatever callbacks get added, they should be added down here and get
gtk-doc documentation above the struct. That should also include some
guidelines on how new devices should implement these (hint: we'd want to
avoid code duplication).
I have the feeling your hooks may be rather x86-specific - have you
checked against any other architecture?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH][RFC 0/14] implement power chip, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 03/14] qdev: remove redundant abort(), liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 02/14] qdev: add power management method, liguang, 2013/03/13
- Re: [Qemu-devel] [PATCH][RFC 02/14] qdev: add power management method,
Andreas Färber <=
- [Qemu-devel] [PATCH][RFC 07/14] acpi: refactor acpi wakeup function, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 09/14] ich9: do lpc's power on by reset function, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 01/14] gitignore: ignore more files, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 06/14] sysemu: remove PowerReason in sysemu.h, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 10/14] piix4: refactor piix4's power callbacks, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 12/14] ps2: call ps2_{kbd, mouse}_reset in kbd_reset, liguang, 2013/03/13
- [Qemu-devel] [PATCH][RFC 08/14] ich9: make lpc's reset also do pm_reset, liguang, 2013/03/13