[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory |
Date: |
Fri, 15 Mar 2013 17:19:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
Il 15/03/2013 17:09, Peter Maydell ha scritto:
> On 15 March 2013 16:00, Paolo Bonzini <address@hidden> wrote:
>> Il 15/03/2013 15:34, Peter Maydell ha scritto:
>>> I rather suspect sysbus_add_io and sysbus_del_io should also be
>>> removed, but since their users are in PPC and x86 platforms I'll
>>> let somebody else do that part :-)
>>
>> sysbus_add_io and sysbus_del_io are actually a good match for the I/O
>> address space of x86, because the model was to have "well-known" port
>> numbers standardized across all platforms. So all the boards would have
>> to know those port addresses if we used sysbus_init_mmio.
>
> Maybe they should just call memory_region_add_subregion()
> directly then? There's nothing sysbus-device-specific about
> what these functions do, they just take a SysBusDevice* and
> totally ignore it...
It affects the OpenFirmware path, but perhaps we can move the
get_fw_dev_path from the Bus to the Device class.
Paolo
- [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory, Peter Maydell, 2013/03/15
- [Qemu-devel] [PATCH v3 1/5] sysbus: make SysBusDeviceClass::init optional, Peter Maydell, 2013/03/15
- [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself, Peter Maydell, 2013/03/15
- [Qemu-devel] [PATCH v3 5/5] sysbus: Remove sysbus_add_memory and sysbus_del_memory, Peter Maydell, 2013/03/15
- [Qemu-devel] [PATCH v3 3/5] milkymist-minimac2: Just expose buffers as a sysbus mmio region, Peter Maydell, 2013/03/15
- [Qemu-devel] [PATCH v3 2/5] musicpal: qdevify musicpal-misc, Peter Maydell, 2013/03/15
- Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory, Paolo Bonzini, 2013/03/15
- Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory, Peter Maydell, 2013/03/28