qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: Print out missing library when confi


From: Qingtang Zhou
Subject: Re: [Qemu-devel] [PATCH] configure: Print out missing library when configure fails
Date: Fri, 15 Mar 2013 23:10:44 +0800


On Fri, Mar 15, 2013 at 7:53 PM, Peter Maydell <address@hidden> wrote:
On 15 March 2013 11:46, Qingtang Zhou <address@hidden> wrote:
> This patch let configure tool print out which library
> is missing besides the qemu feature name when it fails.

just fyi, this is going to clash badly with the patch I posted to
the list yesterday to abstract out error message printing better.
oops, sorry, I just read your patches, they look
nice, so please ignore mine.

> @@ -2955,7 +2960,7 @@ if test "$usb_redir" != "no" ; then
>          libs_softmmu="$libs_softmmu $usb_redir_libs"
>      else
>          if test "$usb_redir" = "yes"; then
> -            feature_not_found "usb-redir"
> +            feature_not_found "usb-redir" "libusbredirparser-0.5"
>          fi
>          usb_redir="no"

This kind of thing seems like it would easily drift out of
date with library and version numbers that QEMU actually checks for.
It's true, maybe it's better to add a version variant
for it.

-- PMM



--
"""
Qt Zhou
Pythoner, Linuxer.
"""

reply via email to

[Prev in Thread] Current Thread [Next in Thread]