[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] pci: Create and use API to determine root buses
From: |
Alex Williamson |
Subject: |
[Qemu-devel] [PATCH 6/7] pci: Create and use API to determine root buses |
Date: |
Thu, 14 Mar 2013 16:01:29 -0600 |
User-agent: |
StGit/0.16 |
Signed-off-by: Alex Williamson <address@hidden>
---
hw/pci/pci.c | 13 +++++++++----
hw/pci/pci.h | 1 +
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 9c394ab..a023d9c 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -302,6 +302,11 @@ bool pci_bus_is_express(PCIBus *bus)
return object_dynamic_cast(OBJECT(bus), TYPE_PCIE_BUS);
}
+bool pci_bus_is_root(PCIBus *bus)
+{
+ return !bus->parent_dev;
+}
+
void pci_bus_new_inplace(PCIBus *bus, DeviceState *parent,
const char *name,
MemoryRegion *address_space_mem,
@@ -360,7 +365,7 @@ PCIBus *pci_register_bus(DeviceState *parent, const char
*name,
int pci_bus_num(PCIBus *s)
{
- if (!s->parent_dev)
+ if (pci_bus_is_root(s))
return 0; /* pci host bridge */
return s->parent_dev->config[PCI_SECONDARY_BUS];
}
@@ -1186,7 +1191,7 @@ static void pci_set_irq(void *opaque, int irq_num, int
level)
/* Special hooks used by device assignment */
void pci_bus_set_route_irq_fn(PCIBus *bus, pci_route_irq_fn route_intx_to_irq)
{
- assert(!bus->parent_dev);
+ assert(pci_bus_is_root(bus));
bus->route_intx_to_irq = route_intx_to_irq;
}
@@ -1651,7 +1656,7 @@ static PCIBus *pci_find_bus_nr(PCIBus *bus, int bus_num)
}
/* Consider all bus numbers in range for the host pci bridge. */
- if (bus->parent_dev &&
+ if (!pci_bus_is_root(bus) &&
!pci_secondary_bus_in_range(bus->parent_dev, bus_num)) {
return NULL;
}
@@ -1659,7 +1664,7 @@ static PCIBus *pci_find_bus_nr(PCIBus *bus, int bus_num)
/* try child bus */
for (; bus; bus = sec) {
QLIST_FOREACH(sec, &bus->child, sibling) {
- assert(sec->parent_dev);
+ assert(!pci_bus_is_root(sec));
if (sec->parent_dev->config[PCI_SECONDARY_BUS] == bus_num) {
return sec;
}
diff --git a/hw/pci/pci.h b/hw/pci/pci.h
index d715e6f..774369c 100644
--- a/hw/pci/pci.h
+++ b/hw/pci/pci.h
@@ -345,6 +345,7 @@ typedef int (*pci_hotplug_fn)(DeviceState *qdev, PCIDevice
*pci_dev,
#define TYPE_PCIE_BUS "PCIE"
bool pci_bus_is_express(PCIBus *bus);
+bool pci_bus_is_root(PCIBus *bus);
void pci_bus_new_inplace(PCIBus *bus, DeviceState *parent,
const char *name,
MemoryRegion *address_space_mem,
- [Qemu-devel] [PATCH 0/7] pci: Create PCI Express bus type, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 1/7] pci: Create and register a new PCI Express TypeInfo, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 2/7] pci: Move PCI and PCIE type defines, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 3/7] pci: Allow PCI bus creation interfaces to specify the type of bus, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 5/7] pci: Create pci_bus_is_express helper, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 4/7] pci: Q35, Root Ports, and Switches create PCI Express buses, Alex Williamson, 2013/03/14
- [Qemu-devel] [PATCH 6/7] pci: Create and use API to determine root buses,
Alex Williamson <=
- [Qemu-devel] [PATCH 7/7] pcie: Mangle types to match topology, Alex Williamson, 2013/03/14
- Re: [Qemu-devel] [PATCH 0/7] pci: Create PCI Express bus type, Michael S. Tsirkin, 2013/03/17