Re: [Qemu-devel] [PATCH V3 2/3] Revert "gdbstub: Do not kill target in system emulation mode"

[Jan Kiszka]

On 2013-03-12 18:31, Fabien Chouteau wrote:
> The requirements described in this patch are implemented by "Add GDB
> qAttached support".
> 
> This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8.
> 
> Signed-off-by: Fabien Chouteau <address@hidden>
> ---
>  gdbstub.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 70d54ce..0e94311 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2185,11 +2185,9 @@ static int gdb_handle_packet(GDBState *s, const char 
> *line_buf)
>              goto unknown_command;
>          }
>      case 'k':
> -#ifdef CONFIG_USER_ONLY
>          /* Kill the target */
>          fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
>          exit(0);
> -#endif
>      case 'D':
>          /* Detach packet */
>          gdb_breakpoint_remove_all();
> 

Reviewed-by: Jan Kiszka <address@hidden>

Provided that v4 of "Add GDB qAttached support" is applied prior to this.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux