Re: [Qemu-devel] [PATCH 3/3] configure: Don't fall back to gthread coroutine backend

[Peter Maydell]

On 14 March 2013 15:54, Paolo Bonzini <address@hidden> wrote:
> Il 14/03/2013 16:25, Peter Maydell ha scritto:
>> The gthread coroutine backend is broken and does not produce a working
>> QEMU; it is only useful for some very limited debugging situations.
>> Clean up the backend selection logic in configure so that it now runs
>> "if on windows use windows; else prefer ucontext; else sigaltstack".
>>
>> To do this we refactor the configure code to separate out "test
>> whether we have a working ucontext", "pick a default if user didn't
>> specify" and "validate that user didn't specify something invalid",
>> rather than having all three of these run together. We also have to
>> adjust the Makefile logic so it doesn't also encode an idea of the
>> default backend.
>
> You need to fix also tests/Makefile (don't mention it, I missed the boat
> for reviewing the patch on qemu-devel).
>
> Perhaps it's simpler to export a single CONFIG_COROUTINE_BACKEND symbol
> from configure to the Makefile?  (This way patch 2 also becomes
> unnecessary).

Yes, that might be good. (Patch 2 we want anyway because there
are a few other places in configure that are currently using
hand-coded tr invocations, but it needn't be in this series
in that case).

-- PMM