[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] chardev: add vte chardev
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH] chardev: add vte chardev |
Date: |
Wed, 13 Mar 2013 10:59:48 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Gerd Hoffmann <address@hidden> writes:
> On 03/13/13 13:29, Anthony Liguori wrote:
>> Gerd Hoffmann <address@hidden> writes:
>>
>>> Kill the dirty hack which hooks gtk vte initialization into the
>>> qemu consoles subsystem. The vte terminals are not related to qemu
>>> consoles at all. This simply doesn't belong there and it stands in
>>> the way when cleaning up the qemu consoles subsystem. So fix it
>>> up, quickly, before it sneaks into a release.
>>
>>
>> My only concern is that if someone had a command line like:
>>
>> qemu -serial stdio -monitor vc
>>
>> It now breaks with your series.
>
> Yes. I'm not worried. The switch to gtk is a pretty big one anyway
> with a bunch of user interface changes. If we want avoid surprises for
> the user at any cost we must not make gtk the default ui.
>
> Also: Once I'm done with the console cleanup it will be easy to make
> 'vc' actually work with gtk.
Please no. 'vc' needs to die. I don't want anyone using it...
>> 'vc' is a graphical chardev and it should be up to what UI layer to
>> decide how to express it
>
> No.
>
> 'vc' is a DisplaySurface filled by the qemu terminal emulation. It's
> generic and works with any UI.
QEMU shouldn't be in the terminal emulation business.
> 'vte' is a chardev data stream linked up to the gtk vte widget.
> Obviously works with gtk only.
>
>> What's the issue your having with console cleanup?
>
> It just doesn't fit into the QemuConsoles at all, and with multiple UI's
> active (such as gtk+vnc at the same time) it doesn't make sense any
> more.
Okay, that makes a bit more sense.
>
> cheers,
> Gerd