[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V9 06/14] block: add check for VM snapshot in bd
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V9 06/14] block: add check for VM snapshot in bdrv_query_snapshot_info_list() |
Date: |
Tue, 12 Mar 2013 13:45:08 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/11/2013 05:23 AM, Wenchao Xia wrote:
> This patch adds a parameter to tell whether return valid snapshots
> for whole VM only.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> block/qapi.c | 42 ++++++++++++++++++++++++++++++++++++++++--
> include/block/qapi.h | 1 +
> qemu-img.c | 3 ++-
> 3 files changed, 43 insertions(+), 3 deletions(-)
> + /* Check logic is connected with load_vmstate():
> + Only check the devices that can snapshot, other devices that can't
> + take snapshot, for example, readonly ones, will be ignored in
> + load_vmstate(). */
> + while ((bs1 = bdrv_next(bs1))) {
> + if (bdrv_can_snapshot(bs1) && bs1 != bs) {
Minor optimization - you could rearrange the conjunct and check 'bs1 !=
bs' first, to avoid the overhead of bdrv_can_snapshot on bs. But that
doesn't stop me from giving:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH V9 03/14] qemu-img: remove unused parameter in collect_image_info(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 05/14] block: add snapshot info query function bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c, Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 06/14] block: add check for VM snapshot in bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/11
- Re: [Qemu-devel] [PATCH V9 06/14] block: add check for VM snapshot in bdrv_query_snapshot_info_list(),
Eric Blake <=
[Qemu-devel] [PATCH V9 02/14] block: distinguish id and name in bdrv_find_snapshot(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 09/14] qmp: add interface query-images, Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 07/14] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 10/14] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 08/14] qmp: add interface query-snapshots, Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 11/14] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/03/11
[Qemu-devel] [PATCH V9 12/14] block: move dump_human_image_info() to block/qapi.c, Wenchao Xia, 2013/03/11