qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c
Date: Sat, 09 Mar 2013 06:10:18 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3

On 03/08/2013 09:00 PM, Wenchao Xia wrote:
> 
>> On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>>>    This file will have internal snapshot related functions.
>>>
>>> Signed-off-by: Wenchao Xia <address@hidden>
>>> ---
>>
>>> --- /dev/null
>>> +++ b/include/block/snapshot.h
>>> @@ -0,0 +1,4 @@
>>> +#ifndef SNAPSHOT_H
>>
>> Introducing a new file without a copyright notice is a no-no.
>>
> 
>   Copy right is notice in snapshot.c, other header files seems
> no copy right declaration, what more should be added?

The copyright of the .c file should be copied to the .h file then.
EVERY file needs a copyright, not just one of a pair of files.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]