[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c
|
From: |
Wenchao Xia |
|
Subject: |
Re: [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c |
|
Date: |
Sat, 09 Mar 2013 12:00:37 +0800 |
|
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 |
> On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>> This file will have internal snapshot related functions.
>>
>> Signed-off-by: Wenchao Xia <address@hidden>
>> ---
>
>> --- /dev/null
>> +++ b/include/block/snapshot.h
>> @@ -0,0 +1,4 @@
>> +#ifndef SNAPSHOT_H
>
> Introducing a new file without a copyright notice is a no-no.
>
Copy right is notice in snapshot.c, other header files seems
no copy right declaration, what more should be added?
--
Best Regards
Wenchao Xia
- Re: [Qemu-devel] [PATCH V8 09/20] block: add image info query function bdrv_query_image_info(), (continued)
- [Qemu-devel] [PATCH V8 10/20] qmp: add interface query-snapshots, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 11/20] qmp: add interface query-images, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 12/20] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 13/20] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 14/20] block: move dump_human_image_info() to block/qapi.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 15/20] block: dump to buffer for bdrv_image_info_dump(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 16/20] hmp: add command info images, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 17/20] block: return bool for bdrv_can_snapshot(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 18/20] block: move snapshot related functions to block/snapshot.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 19/20] block: move bdrv_snapshot_dump() to block/qapi.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 20/20] block: rename bdrv_query_info() to bdrv_query_block_info(), Wenchao Xia, 2013/03/07
- Re: [Qemu-devel] [PATCH V8 00/20] qmp/hmp interfaces for internal snapshot info, Markus Armbruster, 2013/03/07