Re: [Qemu-devel] [PATCH V8 05/20] qemu-img: remove unused parameter in collect_image_info()

[Eric Blake]

On 03/06/2013 11:07 PM, Wenchao Xia wrote:
>   Parameter *fmt was not used, so remove it.
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> Signed-off-by: Wenchao Xia <address@hidden>

Typically, these annotations should be kept in chronological order.
That is, the first line should always be a Signed-off-by (you have to
write a patch before anyone else can add their Reviewed-by).  Also, we
tend to avoid blank lines in the attribution section.  So, the preferred
way to write this would be:

Signed-off-by: Wenchao Xia <address@hidden>
Reviewed-by: Eric Blake <address@hidden>

But that's cosmetic, and my review still stands.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature