[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] osdep: replace setsockopt by qemu_setsockopt
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] osdep: replace setsockopt by qemu_setsockopt |
Date: |
Fri, 8 Mar 2013 10:22:23 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 06, 2013 at 10:29:16PM +0800, Lei Li wrote:
> Fix the compiler warning when cross build qemu-ga
> for windows by using qemu_setsockopt() instead of
> setsockopt().
>
> util/osdep.c: In function 'socket_set_nodelay':
> util/osdep.c:69:5: warning: passing argument 4 of 'setsockopt' from
> incompatible pointer type [enabled by default]
> In file included from /home/lei/qemu_b/include/sysemu/os-win32.h:30:0,
> from /home/lei/qemu_b/include/qemu-common.h:46,
> from util/osdep.c:48:
> /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:990:63: note:
> expected 'const char *' but argument is of type 'int *'
>
> Signed-off-by: Lei Li <address@hidden>
> ---
>
> Change since v1:
> - Use qemu_setsockopt() instead of open-coding suggested by Stefan.
>
> ---
> util/osdep.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan