[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V8 09/20] block: add image info query function bdrv_
From: |
Wenchao Xia |
Subject: |
[Qemu-devel] [PATCH V8 09/20] block: add image info query function bdrv_query_image_info() |
Date: |
Thu, 7 Mar 2013 14:07:14 +0800 |
This patch adds function bdrv_query_image_info(), which will
retrieve image info in qmp object format. The implementation are
based on the code moved from qemu-img.c, but use block layer
function to get snapshot info.
Signed-off-by: Wenchao Xia <address@hidden>
---
block/qapi.c | 39 ++++++++++++++++++++++++++++++++-------
include/block/qapi.h | 7 +++----
qemu-img.c | 7 ++-----
3 files changed, 37 insertions(+), 16 deletions(-)
diff --git a/block/qapi.c b/block/qapi.c
index a90b4c7..0c3055f 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -108,18 +108,22 @@ int bdrv_query_snapshot_info_list(BlockDriverState *bs,
return 0;
}
-void bdrv_collect_image_info(BlockDriverState *bs,
- ImageInfo *info,
- const char *fmt)
+/* return 0 on success, and @p_info will be set only on success. */
+int bdrv_query_image_info(BlockDriverState *bs,
+ ImageInfo **p_info,
+ Error **errp)
{
uint64_t total_sectors;
- char backing_filename[1024];
+ const char *backing_filename;
char backing_filename2[1024];
BlockDriverInfo bdi;
+ int ret;
+ Error *err = NULL;
+ ImageInfo *info = g_new0(ImageInfo, 1);
bdrv_get_geometry(bs, &total_sectors);
- info->filename = g_strdup(filename);
+ info->filename = g_strdup(bs->filename);
info->format = g_strdup(bdrv_get_format_name(bs));
info->virtual_size = total_sectors * 512;
info->actual_size = bdrv_get_allocated_file_size(bs);
@@ -136,8 +140,8 @@ void bdrv_collect_image_info(BlockDriverState *bs,
info->dirty_flag = bdi.is_dirty;
info->has_dirty_flag = true;
}
- bdrv_get_backing_filename(bs, backing_filename, sizeof(backing_filename));
- if (backing_filename[0] != '\0') {
+ backing_filename = bs->backing_file;
+ if (backing_filename && backing_filename[0] != '\0') {
info->backing_filename = g_strdup(backing_filename);
info->has_backing_filename = true;
bdrv_get_full_backing_filename(bs, backing_filename2,
@@ -154,4 +158,25 @@ void bdrv_collect_image_info(BlockDriverState *bs,
info->has_backing_filename_format = true;
}
}
+
+ ret = bdrv_query_snapshot_info_list(bs, &info->snapshots, false, &err);
+ switch (ret) {
+ case 0:
+ info->has_snapshots = true;
+ break;
+ /* recoverable error */
+ case -ENOMEDIUM:
+ error_free(err);
+ break;
+ case -ENOTSUP:
+ error_free(err);
+ break;
+ default:
+ error_propagate(errp, err);
+ qapi_free_ImageInfo(info);
+ return ret;
+ }
+
+ *p_info = info;
+ return 0;
}
diff --git a/include/block/qapi.h b/include/block/qapi.h
index 4842c12..675df0c 100644
--- a/include/block/qapi.h
+++ b/include/block/qapi.h
@@ -8,8 +8,7 @@ int bdrv_query_snapshot_info_list(BlockDriverState *bs,
SnapshotInfoList **p_list,
bool vm_snapshot,
Error **errp);
-void bdrv_collect_image_info(BlockDriverState *bs,
- ImageInfo *info,
- const char *filename,
- const char *fmt);
+int bdrv_query_image_info(BlockDriverState *bs,
+ ImageInfo **p_info,
+ Error **errp);
#endif
diff --git a/qemu-img.c b/qemu-img.c
index 7786953..59d900a 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1733,11 +1733,8 @@ static ImageInfoList *collect_image_info_list(const char
*filename,
goto err;
}
- info = g_new0(ImageInfo, 1);
- bdrv_collect_image_info(bs, info, filename, fmt);
- if (!bdrv_query_snapshot_info_list(bs, &info->snapshots,
- false, NULL)) {
- info->has_snapshots = true;
+ if (bdrv_query_image_info(bs, &info, NULL)) {
+ goto err;
}
elem = g_new0(ImageInfoList, 1);
--
1.7.1
- Re: [Qemu-devel] [PATCH V8 07/20] block: add snapshot info query function bdrv_query_snapshot_info_list(), (continued)
- [Qemu-devel] [PATCH V8 05/20] qemu-img: remove unused parameter in collect_image_info(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 06/20] block: move collect_snapshots() and collect_image_info() to block/qapi.c, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 08/20] block: add filter for vm snapshot in bdrv_query_snapshot_info_list(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 09/20] block: add image info query function bdrv_query_image_info(),
Wenchao Xia <=
- [Qemu-devel] [PATCH V8 10/20] qmp: add interface query-snapshots, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 11/20] qmp: add interface query-images, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 12/20] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 13/20] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/03/07
- [Qemu-devel] [PATCH V8 01/20] build: add block/snapshot.c, Wenchao Xia, 2013/03/07