[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] qga: implement qmp_guest_get_vcpus() for
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs |
|
Date: |
Wed, 06 Mar 2013 16:15:33 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 |
On 03/06/2013 02:59 PM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
> qga/commands-posix.c | 146 +++++++++++++++++++++++++++++++++++++++++++++++--
> 1 files changed, 140 insertions(+), 6 deletions(-)
>
> @@ -1027,6 +1031,136 @@ error:
> return NULL;
> }
>
> +#define SYSCONF_EXACT(name, err) sysconf_exact((name), #name, (err))
Technically, the inner () are redundant (in a parameter list, there is
no syntax that can be rendered differently if you called
sysconf_exact(name, #name, err)); but I don't mind keeping them for
style purposes (the rule of thumb of parenthesizing macro parameters for
safety is a bit easier to remember if you always do it, even when it is
redundant).
> + vcpu->has_can_offline = true; /* lolspeak ftw */
Indeed :)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature