[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 4/8] add a new runstate: RUN_STATE_GUEST_PAN
|
From: |
Hu Tao |
|
Subject: |
Re: [Qemu-devel] [PATCH v13 4/8] add a new runstate: RUN_STATE_GUEST_PANICKED |
|
Date: |
Wed, 6 Mar 2013 17:03:18 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 05, 2013 at 09:26:18AM +0100, Paolo Bonzini wrote:
> Il 05/03/2013 04:17, Hu Tao ha scritto:
> > Will
> >
> > if (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
> > runstate_check(RUN_STATE_SHUTDOWN) ||
> > runstate_check(RUN_STATE_GUEST_PANICKED)) {
> > runstate_set(RUN_STATE_PAUSED);
> > }
> >
> > be OK? Or I must be misunderstanding you.
> >
>
> Please move
>
> return (runstate_check(RUN_STATE_INTERNAL_ERROR) ||
> runstate_check(RUN_STATE_SHUTDOWN) ||
> runstate_check(RUN_STATE_GUEST_PANICKED));
>
> to a separate function (runstate_needs_reset for example), so that you
> can reuse it in the two or three places that need it.
See it now. Thanks!