Re: [Qemu-devel] [PATCH 2/3] net: introduce lock to protect NetClientState's send_queue

[Paolo Bonzini]

Il 04/03/2013 15:49, Stefan Hajnoczi ha scritto:
> > Use nc->transfer_lock to protect the nc->peer->send_queue. All of the
> 
> Please use consistent names: the lock protects ->send_queue so it's best
> called send_queue_lock or send_lock.

In fact, it's a bit strange to use nc->something_lock to lock something
in nc->peer.  Please add the lock to NetQueue and include/net/queue.h.

nc->peer shouldn't need a lock.  It is immutable, isn't it?

Paolo