[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 6/8] introduce a new qom device to deal with
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v13 6/8] introduce a new qom device to deal with panicked event |
Date: |
Mon, 04 Mar 2013 11:21:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 04/03/2013 11:10, Christian Borntraeger ha scritto:
> + //disabled wait: we either
> + //do a
> + //monitor_protocol_event(QEVENT_GUEST_PANICKED, whatever);
> + //or
> + //or call into pvevent
> r = EXCP_HALTED;
> break;
> case ICPT_CPU_STOP:
>
>
> I would prefer to just use the monitor_protocol_event, on the other hand
> a call into pvent could make it configurable.
I asked in my review to make pvevent not configurable, So
monitor_protocol_event(QEVENT_GUEST_PANICKED);
vm_stop(RUNSTATE_GUEST_PANICKED);
would do I guess.
Feel free to submit a patch to qemu-devel. Hu, please take any patch
that Christian submits and incorporate it in your series for future posting.
Paolo