[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage |
Date: |
Fri, 01 Mar 2013 14:53:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 01/03/2013 14:52, Eric Blake ha scritto:
> On 03/01/2013 06:31 AM, Peter Lieven wrote:
>> at the beginning of migration all pages are marked dirty and
>> in the first round a bulk migration of all pages is performed.
>>
>> currently all these pages are copied to the page cache regardless
>> if there are frequently updated or not. this doesn't make sense
>> since most of these pages are never transferred again.
>>
>> this patch changes the XBZRLE transfer to only be used after
>> the bulk stage has been completed. that means a page is added
>> to the page cache the second time it is transferred and XBZRLE
>> can benefit from the third time of transfer.
>>
>> since the page cache is likely smaller than the number of pages
>> its also likely that in the second round the page is missing in the
>> cache due to collisions in the bulk phase.
>>
>> on the other hand a lot of unneccssary mallocs, memdups and frees
>
> s/unneccssary/unnecessary/
>
>> are saved.
>>
>> Signed-off-by: Peter Lieven <address@hidden>
>
> Do you have any benchmark numbers? At any rate, the explanation seems
> sound, so a benchmark should show this.
It probably would be much less of a problem with the pending patches to
move RAM migration out of the big QEMU lock. However, the explanation
makes sense.
Paolo
>> ---
>> arch_init.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
- [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/01
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Eric Blake, 2013/03/01
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/01
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Eric Blake, 2013/03/01
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/01
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Eric Blake, 2013/03/01
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/01
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Eric Blake, 2013/03/01
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/04
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Paolo Bonzini, 2013/03/04
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Peter Lieven, 2013/03/04
- Re: [Qemu-devel] [PATCH] migration: use XBZRLE only after bulk stage, Orit Wasserman, 2013/03/04