[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] configure: Put cross compile flags in EX
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] configure: Put cross compile flags in EXTRA_CFLAGS |
Date: |
Thu, 28 Feb 2013 14:52:03 +0000 |
On 19 February 2013 04:16, Peter Crosthwaite
<address@hidden> wrote:
> The cross compile CFLAGS are needed to properly build pixman (and any other
> submodules). Only the EXTRA_CFLAGS set is passed to submodules not
> QEMU_CFLAGS,
> so put the cross compile flags in EXTRA_CFLAGS instead.
>
> Signed-off-by: Peter Crosthwaite address@hidden>
> ---
>
> configure | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/configure b/configure
> index bf5970f..088909b 100755
> --- a/configure
> +++ b/configure
> @@ -239,8 +239,7 @@ for opt do
> ;;
> --cpu=*) cpu="$optarg"
> ;;
> - --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS"
> - EXTRA_CFLAGS="$optarg"
> + --extra-cflags=*) EXTRA_CFLAGS="$optarg"
> ;;
> --extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS"
> EXTRA_LDFLAGS="$optarg"
>
> +QEMU_CFLAGS="$EXTRA_CFLAGS $QEMU_CFLAGS"
> +
> default_target_list=""
This change means that flags supplied by the user in --extra-cflags
are not used in compile_prog/compile_object/check_define tests
that happen before this point where we add the EXTRA_CFLAGS
to QEMU_CFLAGS, but then they are used after that. This doesn't
seem like a good thing (it would be reverting a fix inserted
by commit e2a2ed0).
-- PMM
[Qemu-devel] [PATCH v2 3/3] configure/Make: Build libfdt from submodule DTC, Peter Crosthwaite, 2013/02/18