Re: [Qemu-devel] [PATCH] net: use socket_set_nodelay() for -netdev socket

[Stefan Hajnoczi]

On Wed, Feb 27, 2013 at 04:49:16PM +0000, Daniel P. Berrange wrote:
> On Wed, Feb 27, 2013 at 03:05:47PM +0100, Stefan Hajnoczi wrote:
> > Reduce -netdev socket latency by disabling the Nagle algorithm on
> > SOCK_STREAM sockets in net/socket.c.  Since we are tunelling Ethernet
> > over TCP we shouldn't artificially delay outgoing packets, let the guest
> > decide packet scheduling.
> > 
> > I already get sub-millisecond -netdev socket ping times on localhost, so
> > there was no measurable difference in my testing.  This won't hurt
> > though and may improve remote socket performance.
> > 
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> 
> ACK.
> 
> Signed-off-by: Daniel P. Berrange <address@hidden>

Hi Dan,
QEMU usually only uses Singed-off-by: for authors and subsystem
maintainers who merge the patch.

Is it okay if I add a Reviewed-by: Daniel P. Berrange
<address@hidden> instead?

Stefan