[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size.
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size. |
Date: |
Wed, 27 Feb 2013 15:53:43 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> > inc_refcounts(bs, res, refcount_table, refcount_table_size,
> > - l2_offset, s->cluster_size);
> > + l2_offset, dedup ? s->hash_block_size : s->l2_size << 3);
>
> Why s->l2_size << 3 instead of s->cluster_size for the non-dedup case?
I wrote it like this so the code would work fine is l2_size is different of
cluster size. It is almost a bugfix.
Regards
Benoît
- [Qemu-devel] [RFC V6 19/33] block: Add qcow2_dedup format and image creation code., (continued)
- [Qemu-devel] [RFC V6 19/33] block: Add qcow2_dedup format and image creation code., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 25/33] qcow2: Serialize write requests when deduplication is activated., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 30/33] qcow2: Integrate SKEIN hash algorithm in deduplication., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 32/33] qemu-iotests: Filter dedup=on/off so existing tests don't break., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 33/33] qcow2: Add qcow2_dedup_init and qcow2_dedup_close., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 08/33] qcow2: Add qcow2_dedup_store_new_hashes., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 27/33] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup., Benoît Canet, 2013/02/06