Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

[Amit Shah]

On (Mon) 04 Feb 2013 [11:59:02], Michael S. Tsirkin wrote:
> On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo Bonzini wrote:
> > Il 03/02/2013 13:11, Michael S. Tsirkin ha scritto:
> > >> >  static Property virtio_serial_properties[] = {
> > >> >      DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, 
> > >> > VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
> > >> > -    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 
> > >> > DEV_NVECTORS_UNSPECIFIED),
> > >> > +    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
> > >> >      DEFINE_PROP_HEX32("class", VirtIOPCIProxy, class_code, 0),
> > >> >      DEFINE_VIRTIO_COMMON_FEATURES(VirtIOPCIProxy, host_features),
> > >> >      DEFINE_PROP_UINT32("max_ports", VirtIOPCIProxy, 
> > >> > serial.max_virtserial_ports, 31),
> > >> > 
> > >> > plus the backwards-compatibility stuff.
> > >> > 
> > >> > Paolo
> > > Makes sense, but the logic in virtio_serial_init_pci is
> > > then dead code and should go away.
> > > 
> > 
> > It won't be dead code for the backwards-compatible machine types (that
> > use DEV_NVECTORS_UNSPECIFIED).
> > 
> > Paolo
> 
> Good point. Ack. Want to post this with proper signature etc?

Gal, do you want to submit a patch for this?

                Amit