[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] slirp: Properly initialize pollfds_idx of new s
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH] slirp: Properly initialize pollfds_idx of new sockets |
Date: |
Wed, 27 Feb 2013 09:22:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-02-26 23:18, Anthony Liguori wrote:
> Jan Kiszka <address@hidden> writes:
>
>> Otherwise we may start processing sockets in slirp_pollfds_poll that
>> were created past slirp_pollfds_fill.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>
> I think there's still something wrong...
>
> Somehow, my char flow series breaks slirp. Prior to the g_poll
> conversion, this was not the case.
>
> I'll look into it more later and post a git tree but FYI. I suspect
> moving the chardevs to GIOChannel is uncovering a latent bug in the
> slirp main loop interaction.
OK, but please pull this fix nevertheless. It is correct and makes
current git master usable again.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH v4 08/10] aio: extract aio_dispatch() from aio_poll(), (continued)
[Qemu-devel] [PATCH v4 09/10] aio: convert aio_poll() to g_poll(3), Stefan Hajnoczi, 2013/02/20
[Qemu-devel] [PATCH v4 10/10] aio: support G_IO_HUP and G_IO_ERR, Stefan Hajnoczi, 2013/02/20
[Qemu-devel] [PATCH v4 07/10] main-loop: drop rfds/wfds/xfds for good, Stefan Hajnoczi, 2013/02/20
Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts, Laszlo Ersek, 2013/02/20
Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts, Michael S. Tsirkin, 2013/02/20
Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts, Christian Borntraeger, 2013/02/21