Re: [Qemu-devel] [PATCH v4 21/23] hw/arm: add Faraday FTSPI020 SPI flash controller support

[Kuo-Jung Su]

2013/2/26 Andreas Färber <address@hidden>:
> Am 26.02.2013 12:08, schrieb Peter Crosthwaite:
>> On Tue, Feb 26, 2013 at 7:14 PM, Kuo-Jung Su <address@hidden> wrote:
>>> From: Kuo-Jung Su <address@hidden>
>>>
>>> The FTSPI020 is an integrated SPI Flash controller
>>> which supports upto 4 flash chips.
>
> "up to"
>

Got it, thanks.

My English sucks, so if it's not too much bother, please help me to
correct my sentence.

>>>
>>> Signed-off-by: Kuo-Jung Su <address@hidden>
>>> ---
>>
>> Please provide change logs below the line as per the patch submission 
>> process.
>
> Let's try not to give contradictory instructions here: The change log
> can be found in the cover letter.
> It does not mention any changes of this file since v3.
>
> http://wiki.qemu.org/Contribute/SubmitAPatch seems to describe a single
> patch only, where as you say the change log is expected below --- rather
> than in the commit message. Copying change logs into every single patch
> of a long series is either troublesome and error-prone when done by hand
> or if --- is inserted into the commit message leads to cherry-picking
> not working as expected. The cover letter needs to be written up anyway,
> so is the easiest solution.

Sorry for my laziness, the change logs would be added to the cover letter
at the incoming v5 patch.


>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



--
Best wishes,
Kuo-Jung Su