[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] PATCH1 - infrastructure for Evaluate breakpoint
|
From: |
Neiman, Anna |
|
Subject: |
Re: [Qemu-devel] [PATCH] PATCH1 - infrastructure for Evaluate breakpoint condition on target.OPC_MAX_SIZE - size of translation buffer - was increased because condition translated bytecode should be executed in one block |
|
Date: |
Tue, 26 Feb 2013 13:57:33 +0000 |
Relating to size of patch - I divided it maximally,
Relating to subject - thank for your note - I'll take it in account next time.
-----Original Message-----
From: Peter Maydell [mailto:address@hidden
Sent: Tuesday, February 26, 2013 3:54 PM
To: Neiman, Anna
Cc: address@hidden; Rozenman, Alex; Schreiber, Amir; Anthony Liguori; Brook,
Paul
Subject: Re: [PATCH] PATCH1 - infrastructure for Evaluate breakpoint condition
on target.OPC_MAX_SIZE - size of translation buffer - was increased because
condition translated bytecode should be executed in one block
On 26 February 2013 13:50, Anna Neiman <address@hidden> wrote:
>
> Signed-off-by: Anna Neiman <address@hidden>
The formatting of your patches is still a mess (huge long
subject, not properly threaded with a cover letter, etc)
and you're still doing too much in one patch.
Hint: "add missing include guards to header files" is
probably a patch of its own.
-- PMM