[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] dataplane: remove EventPoll in favor of AioC
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] dataplane: remove EventPoll in favor of AioContext |
Date: |
Tue, 26 Feb 2013 11:47:02 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 22, 2013 at 10:40:34AM +0100, Paolo Bonzini wrote:
> During the review of the dataplane code, the EventPoll API morphed itself
> (not concidentially) into something very very similar to an AioContext.
> Thus, it is trivial to convert virtio-blk-dataplane to use AioContext,
> and a first baby step towards letting dataplane talk directly to the
> QEMU block layer.
>
> The only interesting note is the value-copy of EventNotifiers. At least
> in my opinion this is part of the EventNotifier API and is even portable
> to Windows. Of course, in this case you should not close the notifier's
> underlying file descriptors or handle with event_notifier_cleanup.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/dataplane/Makefile.objs | 2 +-
> hw/dataplane/event-poll.c | 100
> ---------------------------------------------
> hw/dataplane/event-poll.h | 40 ------------------
> hw/dataplane/virtio-blk.c | 48 +++++++++++++---------
> 4 files changed, 29 insertions(+), 161 deletions(-)
> delete mode 100644 hw/dataplane/event-poll.c
> delete mode 100644 hw/dataplane/event-poll.h
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan